WomenInSoftwareEngineeringJP / speak-her-db

Database of women speakers in Japan.
https://speakher.jp
MIT License
25 stars 25 forks source link

Speak-32 Add search algorithm #195

Closed tuul-wq closed 3 years ago

tuul-wq commented 4 years ago

Resolves #32

Description of changes in this PR Enabled Search component which has 2 autocomplete fields with a prepopulated dropdown. Fields can be cleared with a cross icon. In case no speakers were found we show NoResultscomponent with corresponding text (translation required). Also adjusted spinner center align as well as margin values to be similar with NoResultscomponent to eliminate footer jumping. Moved PaginationRowin title row, to remove jumping between search form and pagination widget.

How do the reviewers QA this?

tuul-wq commented 4 years ago

@ann-kilzer resolved kebab conflict; added more info for QA.

tuul-wq commented 3 years ago

@ann-kilzer updated PR

tuttiq commented 3 years ago

Hi @tuul-wq ! Any plans to come back to this PR?