WomenInSoftwareEngineeringJP / speak-her-db

Database of women speakers in Japan.
https://speakher.jp
MIT License
25 stars 25 forks source link

Translate find speaker #216

Closed Kimmym6a closed 3 years ago

Kimmym6a commented 3 years ago

Resolves #[Issue number] Please link to the related issue, using the [Resolves] keyword only if the PR completes the entire issue I translated the find speaker part. This is also related #193 issue. She/her and he/him are not 第一人称 it is 第三人称(it means the name is called from the third person). I felt It sounds a very technical expression, not appropriate for an individual profile. Then I put 呼称. It includes a nickname, pronouns, any name. At least it sounds like "This is how to call them without calling the real name". When I find more appropriate words, I would like to update.

Proposed Changes Translating the find speaker part.

find_speaker_en find_speaker_jp pronouns_en pronouns_jp

Description of changes in this PR I translated that part.

Testing Plan

How do the reviewers QA this? Feel free to write unit tests or describe manual testing steps here