241 no more email relay

WomenInSoftwareEngineeringJP / speak-her-db

Database of women speakers in Japan.

https://speakher.jp

MIT License

25 stars 25 forks source link

241 no more email relay #264

Closed ann-kilzer closed 2 years ago

ann-kilzer commented 2 years ago

Resolves #241

Farewell Email Relay

Proposed Changes

remove email relay
add a message to instruct users on how to contact speakers
enhance the color of the Social Media icons so users can easily find contact info
lower the color of the email button because it's just legacy

Testing Plan

Look at the list of speakers. Click on the ✉️ icon and check the message. Ensure that clicking OK closes the dialog.

Ania-chan commented 2 years ago

@ann-kilzer I run the repo locally but I noticed all the social media links are garbled and are redirecting to non existing links like http://eexiwzj.nphzdoi.de/

ann-kilzer commented 2 years ago

@Ania-chan It's probably because you're using the test database... that has fake names and data. Please check

ann-kilzer commented 2 years ago

The deploy preview should give accurate links because it connects to the real DB, not test: https://deploy-preview-264--speak-her-db.netlify.app/

Ania-chan commented 2 years ago

@ann-kilzer Thanks! I can see everything working and I don't have any issue with the code :)