Wonder-Technology / Wonder-Editor

Functional 3D Webgl Editor
https://yyc-git.github.io/wonder/index.html
Apache License 2.0
172 stars 46 forks source link

Amy finish focus gameObject #26

Closed AmyOrz closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #26 into dev will decrease coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #26      +/-   ##
==========================================
- Coverage   87.31%   87.29%   -0.02%     
==========================================
  Files         347      348       +1     
  Lines        5874     5897      +23     
==========================================
+ Hits         5129     5148      +19     
- Misses        745      749       +4
Impacted Files Coverage Δ
...service/stateTuple/logic/GameObjectLogicService.js 78.26% <0%> (-11.22%) :arrow_down:
lib/es6_global/src/core/job/init/InitHotKeysJob.js 88.88% <0%> (-0.59%) :arrow_down:
.../core/composable_component/utils/FocusDataUtils.js 100% <0%> (ø)
...Tuple/logic/ArcballCameraControllerLogicService.js 85.71% <0%> (+2.69%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1b0a997...bfaa6b7. Read the comment docs.

yyc-git commented 5 years ago

TODO feat: if has no current scene tree node, do nothing

yyc-git commented 5 years ago

TODO fix: split isCurrentSceneTreeNodeCanBeOperate to isCurrentSceneTreeNodeSceneGameObject, isCurrentSceneTreeNodeSceneChildren