WonderInventions / node-webrtc

node-webrtc is a Node.js Native Addon that provides bindings to WebRTC M98
Other
109 stars 8 forks source link

FIX RTC audiosink not working #10

Closed MatthD closed 5 months ago

MatthD commented 5 months ago

It just fix RTCaudiosink ondata never fired issue

By reverting one commit that seems to cause this issue and add some unit test

duvallj commented 5 months ago

I've created https://github.com/WonderInventions/node-webrtc/pull/11 as an alternative approach; turns out the previous maintainer was vendoring a webrtc component themselves, for dubious benefits, so I went ahead and got rid of this file, and hopefully that fixes things?

duvallj commented 5 months ago

closed in favor of https://github.com/WonderInventions/node-webrtc/pull/11