search

WonderInventions / node-webrtc

node-webrtc is a Node.js Native Addon that provides bindings to WebRTC M98
Other
120 stars 9 forks source link

Audio broken #13

Open MatthD opened 6 months ago

MatthD commented 6 months ago

Since the last merge , the audio is completely broken with noises sound. I just tried on my side to compile everything with the first solution presented to resolve ondata never fired , it fixes , runtime is ok .

duvallj commented 6 months ago

Sorry about the regression, do you have a test for this by any chance? I'd like some way to prevent future regressions like this

duvallj commented 6 months ago

@MatthD I just pushed some commits to the develop branch that should use your first solution instead, do you mind testing?

MatthD commented 6 months ago

Hum good catch, the unit tests couldn't have identified that, but we can think about something generating audio that we could check manually. Will give it a try

duvallj commented 6 months ago

I believe I have reverted all the problematic commits at this point, is this bug still happening?