search

WonderLandxD / opensdpc

Python library for processing whole slide images (WSIs) in sdpc format
38 stars 8 forks source link

Implementation of get_best_level_for_downsample() #5

Closed MrPeterJin closed 1 year ago

MrPeterJin commented 1 year ago

Hi,

Thanks for your wonderful work. However, Is there a possibility for you to implement get_best_level_for_downsample() like the Openslide package offers?

Reference: https://openslide.org/api/python/#openslide.OpenSlide.get_best_level_for_downsample

WonderLandxD commented 1 year ago

Hello, thank you for your feedback! Since our team does not currently have a need for this function, we have not considered adding it at this time when making the library public. However, in the future, when the appropriate time comes, we will consider incorporating some common functions of Openslide. Please stay tuned for updates!

MrPeterJin commented 1 year ago

Thanks for your reply. Would you mind if I create a Pull Request if I implement this function?

WonderLandxD commented 1 year ago

Certainly! Thank you very much for your help. Your contribution is valuable to the community.

MrPeterJin commented 1 year ago

Certainly! Thank you very much for your help. Your contribution is valuable to the community.

Please check #6.

MrPeterJin commented 1 year ago

Certainly! Thank you very much for your help. Your contribution is valuable to the community.

Hi, is there any problem with this PR? Since the page is in inactivity state for 2 days.

WonderLandxD commented 1 year ago

Certainly! Thank you very much for your help. Your contribution is valuable to the community.

Hi, is there any problem with this PR? Since the page is in inactivity state for 2 days.

Sorry for the delayed response! Our team is quite busy these days, you can manually modify the local environment to execute the function first, we expect to upload a new version next week. Thank you for your positive feedback!