Wonderfall / docker-rtorrent-flood

75 stars 45 forks source link

Setting unwanted permissions for shared directories #25

Open JeremyMahieu opened 3 years ago

JeremyMahieu commented 3 years ago

https://github.com/Wonderfall/docker-rtorrent-flood/blob/02122e670c1b5869e85ba0485d5650ae770872dc/rootfs/usr/local/bin/run.sh#L9

/data is usually a directory that contains all the finished torrent data. This means it's probably shared with other services. Setting the owner by default to "991:991" or to anything is very annoying. It means other services will stop working because of (re)starting rtorrent.

Wouldn't it be better to check permissions, log a warning if read/write is not permitted and stop?