search

Wonderfall / dockerfiles

Discontinued. Fork at your will.
Creative Commons Zero v1.0 Universal
391 stars 170 forks source link

fixed syntax error #190

Closed JanWelker closed 7 years ago

JanWelker commented 7 years ago

Looks like you accidental typed a pipe instead of a slash.

Cheers, Jan

xataz commented 7 years ago

Hi,

It isn't an error, ${BASE_URL} can contain one or more slash, so he use a pipe in delimiter for sed. If he use a slash for this, sed couldn't differentiate the delimiter from slash of the URL.

Regards, XataZ

JanWelker commented 7 years ago

Hi,

makes sense but does not seem to work:

echo base_url: False | sed -e "s|base_url : False|base_url : https://google.de|g" base_url: False

sed --version sed (GNU sed) 4.2.2

Are you guys using the OSX sed?

Cheers, Jan

Wonderfall commented 7 years ago

I can confirm what @xataz said, I'm using pipe as delimiter since there are URLs. I didn't try with macOS but we're using Alpine Linux and there's no issue with it. :)

xataz commented 7 years ago

it works : 

$ echo base_url : False | sed -e 's|base_url : False|base_url : https://google.de|g'
base_url : https://google.de

In your example, you have forgotten between base_url and :

JanWelker commented 7 years ago

My mistake. Thanks for the clarification.