search

Wonderfall / dockerfiles

Discontinued. Fork at your will.
Creative Commons Zero v1.0 Universal
392 stars 170 forks source link

[boring-nginx] Brotli build failing for over a month #252

Open 1n5aN1aC opened 7 years ago

1n5aN1aC commented 7 years ago

I can't figure out exactly what is causing it, but boring-nginx builds have been failing for over a month.

It appears to be something amiss in the Brotli download & build process, as if I split out the RUN commands in the dockerfile, that is section that errors out.

1n5aN1aC commented 7 years ago

Update: this appears to be an upstream issue? https://github.com/bagder/libbrotli/issues/45

1n5aN1aC commented 7 years ago

Looks like fixes are either to add this right before the 'make' command: && mkdir brotli/c/tools/.deps && touch brotli/c/tools/.deps/brotli-brotli.Po

Or to wait for the problem to be fixed in libbrottli

1n5aN1aC commented 7 years ago

I can confirm that the 'Fix' Does work, here's my example: (ignore the travis junk) https://github.com/1n5aN1aC/dockerfiles/commit/505f87bfd3cbdab8cc27b93f629e516fd79d2b80

It does appear to build correctly now as well: https://travis-ci.org/1n5aN1aC/dockerfiles/builds/292223640

Feel free to close this issue implementing it, asking for a pull request, or just waiting for an upstream fix.