search

Wondermarin / react-color-palette

🎨 Lightweight Color Picker component for React.
https://codesandbox.io/s/react-color-palette-2zw8q
MIT License
277 stars 30 forks source link

Updating the colour by typing in the hex input doesn't call onChangeComplete #35

Closed peetjvv closed 1 year ago

peetjvv commented 2 years ago

My Environment

Dependency Version
Node.JS version v16.13.2
react-color-palette version v6.2.0

Expected Behavior:

Changing the colour in the hex input should call the onChangeComplete callbackfn if the user entered a valid hex value.

Actual Behavior:

Changing the colour in the hex input only calls the onChange callbackfn (even if the value entered is invalid) and not the onChangeComplete callbackfn.

Additional Context:

For my use-case I only wrote this issue for the hex value, but I can imagine the same would apply for the RGB and HSL values.

levikline commented 1 year ago

@Wondermarin Are there plans to resolve this bug?

Wondermarin commented 1 year ago

Dropped in v7