search

WoochanLee / BalanceTetris

Tetris built with vanilla javascript
9 stars 10 forks source link

add clear line sound #4

Closed oh3vci closed 3 years ago

oh3vci commented 3 years ago

I added clear line sound and fixed replaying sound logic.

WoochanLee commented 3 years ago

Thanks for your help!

But, the line clear sound looks too flashy. It felt good at first, but as I keep listening, I think it might be annoying to some users. Any other sound?

Anyway, maybe we need to add sounds on/off option too.

WoochanLee commented 3 years ago

And for code quality, I think we have to make sounds managing class. If more sound codes such as background music are added, the code will be complicated.

oh3vci commented 3 years ago

And for code quality, I think we have to make sounds managing class. If more sound codes such as background music are added, the code will be complicated.

I will implement it later