search

Woolicious98 / pe

0 stars 0 forks source link

If data directory is missing midway, all data will be lost forever. #12

Open Woolicious98 opened 3 years ago

Woolicious98 commented 3 years ago

image.png

image.png

Steps taken: Simulate a accidental data directory removal.

During midway of program, remove the data directory / rename the data directory.

The data will no longer be saved.

At the last step could ensure that if the data directory does note exists, recreate it and the files.

nus-pe-script commented 3 years ago

Team's Response

Imagine playing a game and deleting the storage files midway while the game is still running. The game crashes. So this is completely expected behaviour for our program. This will only happen rarely so we did not consider this in scope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Sorry, but I do not understand your analogy of game crashing. In this scenario, it is to represent if there are any fallbacks on saving data if the data directory were not created initially, there is no crashing of the program.

If I infer correctly, you are saying that the program will crash when I delete the the data directory which is not the case.

Furthermore, this could be a common issue due to how OS handles file system in which a possible OS lock could happen when initially running the program, resulting data directory to be missing.

This clearly is within scope and is a case that should be handled when writing to the filesystem as it affect / disables the functionality of your storage component.