Open deftdawg opened 2 weeks ago
Hello @deftdawg,
Thanks for your PR and your interest in the project.
I will need some time to review your code and make some tests.
I can already say you that the use of torch==2.2.0 will break audiocraft-based modules, and it is not an option. If it's a pre-requisite for use on NixOS, then it's a no go.
Same for the update of numpy to 1.26.4 : bad idea ...
Thanks again
No worries, I bumped numpy to 1.26.4 because my install was defaulting to Python 3.12, eventually I had to downgrade to 3.11, I'll see about reverting that when I have another go to see if I can get RoCM running.
Leave it open til I get a chance to work on it some more (or cherry pick parts of it). All good 😀
Python 3.12 won't work with torch==2.1.0 :( ... (at least not on systems i've deployed biniou).
Leave it open til I get a chance to work on it some more (or cherry pick parts of it). All good 😀
Of course ! I'll be really happy to merge your PR if we can find a way to make it work efficiently !
And you can take your time, as I've very few time to work on biniou these days ...
@deftdawg,
Thanks for your modifications.
I'll watch it asap, but be patient : there's a lot of things I want to test before merging your pull request.
No worries, I'm still poking away at it gonna try to get RoCM going and maybe intel arc since I have those 2 GPUs on hand
It runs as it is...
To do: