MostHated
commented
4 years ago Looking a bit more into this:
It looks like there is a possibility that the Component Types:
// --- Starting line 79 in HierarchyDecoratorSettings.cs
/// <summary>
/// List of all components
/// Required for easier handling of serialization
/// </summary>
public List<ComponentType> components;that were stored in the ScriptableObject that was saved as HierarchyDecorator.unitypackage using Unity 2019.x differs from the available Types in 2020.1,
If you see below this was just one quick one that I saw when looking at the ScriptableObject's data that came directly out of the HierarchyDecorator.unitypackage vs a new one I create myself.
(Upon creating the Settings.asset manually, it was lacking a bunch of default settings, but also, the init processes and HierarchyDecoratorSettings.GetOrCreateSettings() didn't seem to work properly, but I didn't dig much into that.)
In here, after trying to do some checking, it seemed like the main issue was the components list, as you see in my comment below.
public void UpdateSettings()
{
if (allTypes == null)
allTypes = ReflectionUtility.GetTypesFromAllAssemblies (typeof (Component));
if (components == null) // Not null, but also the stored components.Count != allTypes.Length above.
{
components = new List<ComponentType> ();
for (int i = 0; i < allTypes.Length; i++)
{
var type = allTypes[i];
components.Add (new ComponentType (type));
}
}
for (int i = 0; i < allTypes.Length; i++)
{
var type = allTypes[i];
if (components[i].type == null)
components[i].UpdateType (type);
if (!shownComponents.ContainsKey (name))
shownComponents.Add (name, components[i]);
}
}
}I was able to get it working properly just just tossing in: components = null; just before the null check so that it would recreate it. Also though, probably checking something like the below might help prevent it:
(components is null || components.Count != allTypes.Length)The UpdateSettings() also seemed to get called what looked like every UI frame due to the following
HierarchyDecorator()
...
EditorApplication.hierarchyWindowItemOnGUI -= HandleObject;
EditorApplication.hierarchyWindowItemOnGUI += HandleObject; // <--Then worked my way down a bit.
HandleObject()
...
GetSettings(); // <--GetSettings();
...
settings.UpdateSettings(); // <--Not sure if that is intended and probably only really seems a bit excessive because it was having errors.
WooshiiDev
----- Edit - Nevermind, lol. After all that I did in the second post, I went to look at the code in the repo and saw you already fixed this and I just had not updated on my end to have the changes. >_<
Hey there again, I was just using the demo from this repo before and just now tried to add the .unitypackage that was included with it into a new project but was unfortunately greeted with errors right away, so I just wanted to make sure you were aware of them.
This was a new project - Unity 2020.1.4f1 with the standard renderer. None of the errors occur in the demo project, I also just tried it with a new 2019.4.9f1 project and there were no errors there. Though, all new projects I have been starting/using use 2020.1.x
With only importing and doing nothing else, the modifications to the hierarchy were applied:
But these two showed up:
Index was out of range
``` ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: index System.ThrowHelper.ThrowArgumentOutOfRangeException (System.ExceptionArgument argument, System.ExceptionResource resource) (atpushing more GUIClips than you are popping
``` GUI Error: You are pushing more GUIClips than you are popping. Make sure they are balanced. UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr, Boolean&) ```I then went to click on the settings SO and the console exploded:
Index was out of range
``` ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: index System.ThrowHelper.ThrowArgumentOutOfRangeException (System.ExceptionArgument argument, System.ExceptionResource resource) (at