search

WootingKb / wooting-rgb-sdk

Customize colors on Wooting Keyboard #WootDev
Mozilla Public License 2.0
62 stars 15 forks source link

added wooting two support #10

Closed GottZ closed 4 years ago

GottZ commented 5 years ago

also ensures the wooting one does not receive the numpad rgb values over usb.

this will prefer the wooting one over the wooting two when loading though.

we should come up with multi keyboard support in the long run i assume.

GottZ commented 5 years ago

this also obsoletes #9 since it's adding actual numpad support

GottZ commented 5 years ago

Emonas#5908 on discord is saying two ansi twooting has strange mapping for the numpad rpg. this needs confirmation.

GottZ commented 5 years ago

@bigbrainafk you can now push to this pull request

GottZ commented 5 years ago

wooting_usb_send_feature(WOOTING_SINGLE_COLOR_COMMAND, 96, 255, 255, 255); to wooting_usb_send_feature(WOOTING_SINGLE_COLOR_COMMAND, 116, 255, 255, 255); does not work properly.

wooting_usb_send_feature(WOOTING_SINGLE_RESET_COMMAND, 0, 0, 0, 96); to wooting_usb_send_feature(WOOTING_SINGLE_RESET_COMMAND, 0, 0, 0, 116); don't work either

to fix this we need a firmware upgrade. besides that, ill add execution prevention to wooting_usb_send_feature for >= 96 in case it's the wooting one.

before i add that, ill have some nap time.

i also have a nice idea how we could add multi keyboard support.

GottZ commented 5 years ago

before merging let me do another commit to prevent the said commands to be executed on wooting ones

GottZ commented 5 years ago

tested by "emulating" wooting one through just changing the wooting one pid and running the said wooting_usb_send_feature iteration. also tested buffering with slightly modified nodejs examples to cover the whole keyboard.

GottZ commented 5 years ago

oh wait there is a bug

PastaJ36 commented 5 years ago

Hey, just wanted to let you know I'm aware of this PR. I just moved country last weekend an we're working through a serious wooting two backlog. I'll be able to take a look tomorrow.

GottZ commented 5 years ago

no worries. i've read your announcement in discord about your absence. take your time.

GottZ commented 5 years ago

oops. sorry for my absense.. i'll dig through this today evening

PastaJ36 commented 5 years ago

Hey, sorry, I've been pretty absent too. In general I think we should focus on just getting the minimum out and look at additional functionality later.

exscape commented 4 years ago

Any progress here? GottZ' pull request worked for me at least with the minimal testing I've done so far. I'll report back if I notice any issues.

I've been trying to debug my issue for hours, and it took a while before I even considered that the SDK didn't have support yet!

PastaJ36 commented 4 years ago

We need to get back on this. GottZ added some extra functionalities that we weren't sure if that would be the way to go, but at this point it's better to have something that works with the Wooting two. I'll bring it up this week to get the Wooting two support added soon. Thanks for the reminder.

simon-wh commented 4 years ago

Thank you very much for your contribution! I'll be making some slight changes on top of what you've given, mainly just to clean up the API for getting information about the device.