search

WootingKb / wooting-rgb-sdk

Customize colors on Wooting Keyboard #WootDev
Mozilla Public License 2.0
62 stars 15 forks source link

linux: Makefile: set appropriate permissions on installed files #30

Closed ghost closed 3 years ago

simon-wh commented 3 years ago

Looks good! Thanks again for these improvements on the Linux makefile. If you've got more in the future I think you could probably group up small ones like this into one

ghost commented 3 years ago

Thanks!

Okay, I will! I had done it that way because I like to keep things separate by feature. But yes, they were very minimal :P I'll still have more patches later ☺

By the way; my Linux Makefile changes can probably all be transferred to the MacOS Makefile. But I didn't do it because I don't have a Mac to test it on. Shall I make a PR for MacOS Makefile?

simon-wh commented 3 years ago

By the way; my Linux Makefile changes can probably all be transferred to the MacOS Makefile. But I didn't do it because I don't have a Mac to test it on. Shall I make a PR for MacOS Makefile?

I don't have a Mac so I'm not certain, but I think all the changes you've made should be suitable for porting over to the Mac makefile(?)

ghost commented 3 years ago

I think so. I think MacOS users probably use the GNU implementation of make, so everything should be the same so far. Except system details. I'll make a PR.