search

WootingKb / wooting-rgb-sdk

Customize colors on Wooting Keyboard #WootDev
Mozilla Public License 2.0
62 stars 15 forks source link

Remove needless memcpys in wooting_usb_send_buffer_v2 #65

Open Sainan opened 11 months ago

Sainan commented 11 months ago

This is basically what I do in my own code and It Just Works™, even tho it looks a bit counterintuitive.

simon-wh commented 9 months ago

Hmmm, it does look like it'll work fine, but it also looks like it's a bit trickier to maintain and for people to immediately understand. Is the cost of the additional memcpy enough to make it worth it?

Sainan commented 9 months ago

Well, the cost if 4 memcpys per packet to send. It's your decision.