Wootric / WootricSDK-iOS

Wootric iOS SDK to show NPS, CSAT and CES surveys
MIT License
13 stars 24 forks source link

Update project and fix deprecations #102

Closed diegoserranoa closed 2 years ago

diegoserranoa commented 2 years ago

Changes

KoCMoHaBTa commented 2 years ago

Tested SPM integration - Getting error that the package contains mixed sources.

Screen Shot 2022-08-31 at 8 36 42

Apparently at some point, some swift files were added. SPM cannot contain both Objcective-C and Swift source files at the same time.

Found the following swift files in the project:

I think, these can easily be converted to Objective-C and everything should be fine

diegoserranoa commented 2 years ago

Aaah yes, these are new ones. Let me check this and update the PR. Thanks for testing @KoCMoHaBTa !

KoCMoHaBTa commented 2 years ago

Thanks for the update. One more issue - the package does not build. You should use #ifdef SWIFTPM_MODULE_BUNDLE instead of #if SWIFTPM_MODULE_BUNDLE

Screen Shot 2022-08-31 at 21 32 59
KoCMoHaBTa commented 2 years ago

Now it works. Thanks @diegoserranoa 🥳

diegoserranoa commented 2 years ago

@KoCMoHaBTa thanks for the review! I pushed a last commit to also fix it for Cocoapods 😅

diegoserranoa commented 2 years ago

Thanks for the help with this! I need someone from my team to also review and approve this and then I can merge and release the new version.