search

WoozyMasta / archimate-ci-image

Archi container image for use in continuous integration pipelines
https://woozymasta.github.io/archimate-ci-image-example/?view=6213
MIT License
40 stars 25 forks source link

Disable github pages, and instead write to folder #12

Closed ahjulstad closed 1 year ago

ahjulstad commented 1 year ago

I would like to publish to an Azure static web app, using this action as part of a workflow together with the https://github.com/Azure/static-web-apps-deploy/tree/v1/ action.

A simple configuration option that allowed me to set the ouput directory of the generated documentation would be great. Is that something that could be added to a wishlist?

ahjulstad commented 1 year ago

This works for my narrow use case, but very ugly: link

WoozyMasta commented 1 year ago

@ahjulstad I looked at the commits, and did not understand what are you doing this?

Why not just set the desired value in the GIT_SUBTREE_PREFIX parameter, but invent BUILDFOLDER?

Why comment part of the logic, leave it as it is, and for the static-web-apps-deploy action, set up publishing from the gh-pages branch of your project.

Just specify in worflow that static-web-apps-deploy run only on the gh-pages branch, and that's it

ahjulstad commented 1 year ago

Thank you for commenting. It could very well be that I am completely misunderstanding things here, github actions are new to me. What I wanted to achieve was to run the archi build step without the github pages upload, so that a subsequent action could do the deploy to SWA.

My code is just to show how I solved it on my end. And as you point out, more is commented than actually needed.

Fra: Maxim Levchenko @.> Sendt: Tuesday, June 27, 2023 10:12:23 AM Til: WoozyMasta/archimate-ci-image @.> Kopi: Åsmund Hjulstad @.>; Mention @.> Emne: Re: [WoozyMasta/archimate-ci-image] Disable github pages, and instead write to folder (Issue #12)

@ahjulstadhttps://github.com/ahjulstad I looked at the commitshttps://github.com/WoozyMasta/archimate-ci-image/compare/master...ahjulstad:archimate-ci-image:master, and did not understand what are you doing this?

Why not just set the desired value in the GIT_SUBTREE_PREFIX parameter, but invent BUILDFOLDER?

Why comment part of the logic, leave it as it is, and for the static-web-apps-deployhttps://github.com/Azure/static-web-apps-deploy action, set up publishing from the gh-pages branch of your project.

Just specify in worflow that static-web-apps-deploy run only on the gh-pages branch, and that's it

— Reply to this email directly, view it on GitHubhttps://github.com/WoozyMasta/archimate-ci-image/issues/12#issuecomment-1609013137, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABSUVOO23FDNAGBFJL4JS2DXNKIWPANCNFSM6AAAAAAZTZHFI4. You are receiving this because you were mentioned.Message ID: @.***>

The information contained in this message may be CONFIDENTIAL and is intended for the addressee only. Any unauthorized use, dissemination of the information or copying of this message is prohibited. If you are not the addressee, please notify the sender immediately by return e-mail and delete this message. Thank you