search

WordPoints / hooks-api

A basic API for hooking into user actions https://github.com/WordPoints/wordpoints/issues/321
GNU General Public License v2.0
0 stars 0 forks source link

Don't display duplicate condition labels #150

Closed JDGrimes closed 8 years ago

JDGrimes commented 8 years ago

Each condition has a title, and also a label for each of its fields:

wordpoints_ _points_types_ _wp_trunk_ _wordpress_-_2016-06-01_09 03 02

As you can see, this is necessary for conditions that include multiple fields, but for conditions that only have a single field, it is odd. Perhaps there is a way that we can hide the title or label for conditions with a single field. Or else maybe we can come up with better labels?

JDGrimes commented 8 years ago

The problem with the equals condition is that it applies to just about any data type. So it is hard to come up with something generic that isn't just, well, "equals". Or, "value". We could possibly generate the label more dynamically in the UI though, I guess...

JDGrimes commented 8 years ago

Like #151, this isn't a blocker, so let's come back to it after we merge this into core.

JDGrimes commented 8 years ago

On a related note, while working on #153, I also noticed that the equals condition doesn't mark the equals field as required. This actually might make sense, because you might want to match when a text field is empty or something. Anyway, I thought that I would note it here.

JDGrimes commented 8 years ago

Closing in favor of https://github.com/WordPoints/wordpoints/issues/412.