search

WordPoints / wordpoints

Points plugin for WordPress
GNU General Public License v2.0
20 stars 15 forks source link

Don't award post author in Comment points hook #257

Closed JDGrimes closed 8 years ago

JDGrimes commented 9 years ago

See https://github.com/WordPoints/wordpoints/issues/221#issuecomment-69514375.

JDGrimes commented 8 years ago

In the new Hooks API (#321), we now award the post author in both the comment and comment received hooks. This is something that we could change if we want to though, by using a filter or a custom extension.

JDGrimes commented 8 years ago

Something to keep in mind is that the affects retroactivity and reversals. If we reverse transactions for the post author when they didn't receive points... but then I guess we can't (and don't) reverse transactions that never occurred in the first place. So we are safe there. The only thing is that points will be awarded for new comments that weren't awarded for old ones, something that is made worse by retroactivity. But I guess retroactivity is really irrelevant here, since we are talking about hooks that already exist.

Anyway, it is a change in behavior, though it doesn't carry any huge issues with it like I thought it might.

JDGrimes commented 8 years ago

I think that our behavior in the new API is correct, as in the future we'll likely make it possible to exclude the author on demand. As far as the existing API goes, since we're going to be deprecating these anyway, I guess that it doesn't make much since to change behavior midstream.