WordPoints / wordpoints

Points plugin for WordPress
GNU General Public License v2.0
20 stars 15 forks source link

Disable editing points types on Points Hooks admin screen #387

Closed JDGrimes closed 8 years ago

JDGrimes commented 8 years ago

The new Points Types screen should be used instead. Originally proposed in https://github.com/WordPoints/hooks-api/issues/23#issuecomment-163254275.

Related: #386

JDGrimes commented 8 years ago

I kind of like this idea, because it reduces code duplication, and means one less thing that we have to retain on the old screen. I also think that it will help users to understand that the new points types screen is the future.

On the other hand, I'm not 100% sure that we ought to do this. That is, we don't need to do this. We can, but it isn't without downsides for the legacy users who are used to the old screen and don't need to use the new one right now. It will interrupt their usual workflow for creating a points type. Although, I suppose that creating a points type isn't really a common event. But editing a points type is a more common thing.

The thing is, I'd like to make this a smooth transition for users. I don't want them to go to the Points Hooks screen, see that there is nowhere to create/edit a points type, and not no what to do. We'd want to show a message with an appropriate link to the Points Types screen, at least on legacy sites. For creating a points type, this is pretty simple and not a big deal. For updating a points type, that is something that users do more often, and forcing them to go somewhere else could be annoying. Though really I suspect that they don't update points types very often either.

All in all, I guess removing these features from the screen is really the best thing to do, for the sake of maintenance and to give users a heads-up that there is a new kid in town (and the old one is going to go away eventually).

JDGrimes commented 8 years ago

Fixed in fc873fb90e13044098c083ced8c793ad27ef559c.