search

WordPoints / wordpoints

Points plugin for WordPress
GNU General Public License v2.0
20 stars 15 forks source link

Network-activating module deactivates other network-activated modules #562

Closed JDGrimes closed 7 years ago

JDGrimes commented 8 years ago

Attempting to network activate a module when there is one already network activated results in this:

wordpoints_ _modules_ _network_admin_buddypress-ms-stable_sites_ _wordpress_-_2016-11-16_15 18 44

The module is activated, but the module that was previously activated is not active any more. It seems like we had a similar issues with the modules before, but I couldn't find it. Maybe it was with the components.

JDGrimes commented 7 years ago

While working on this I've discovered that passing an invalid path to wordpoints_activate_module() will result in errors if WordPoints is network active, via is_network_only_wordpoints_module(). That function is documented as requiring a valid path or else giving errors, so we really need to move the path validation of the module to before we perform that check.

JDGrimes commented 7 years ago

Reopening in case we do a 2.1.6.