WordPoints / wordpoints

Points plugin for WordPress
GNU General Public License v2.0
20 stars 15 forks source link

Run extension deactivation actions when WordPoints is deactivated #712

Open JDGrimes opened 7 years ago

JDGrimes commented 7 years ago

When an extension is deactivated, an action is fired that the extension can hook into to run certain code on deactivation. For example, it is common practice to deregister any cron jobs on deactivation, since they don't need to run and the callback function won't be loaded. These jobs then need to be registered again on reactivation.

However, when WordPoints itself is deactivated, the deactivation code for the extensions is not automatically triggered. The extension could hook into the plugin's deactivation action as well as it's own deactivation action. But should it really have to do that manually? Shouldn't WordPoints be responsible for triggering these actions automatically? And then shouldn't it likewise run the activation hooks for the active extensions on reactivation? (The extensions wouldn't actually be activated/deactivated, we'd just be running the actions.)

JDGrimes commented 7 years ago

The same could also be said for components, especially since they are mainly internal to begin with. However, the core components are not actually hooking into their de/activation at all right now, so the point is largely moot at the moment.