WordPress / Advanced-administration-handbook

WordPress Advanced Administration Handbook. This handbook will have the most technical, general, documentation about WordPress.
https://developer.wordpress.org/advanced-administration/
GNU General Public License v2.0
92 stars 569 forks source link

Network Admin Settings - Default upload file types & broken link #240

Open WRasada opened 1 year ago

WRasada commented 1 year ago

Issue Description

The default upload file types are incorrect and there is a formatting issue and broken link.

URL of the Page with the Issue

https://wordpress.org/documentation/article/network-admin-settings-screen/#upload-file-types

Section of Page with the issue

Upload file types

Why is this a problem?

The default list is different than what the schema sets: https://github.com/WordPress/WordPress/blob/37e599fb3ebe4452009cc598fd8783261b7e3b3b/wp-admin/includes/schema.php#L1243-L1281

This generates a default list that comes out to:

jpg jpeg png gif webp mov avi mpg 3gp 3g2 midi mid pdf doc ppt odt pptx docx pps ppsx xls xlsx key mp3 ogg flac m4a wav mp4 m4v webm ogv flv

The notable difference is that this does not contain wmv or m2ts as the documentation currently states and m2ts is not a supported mime type in get_mime_types(): https://github.com/WordPress/wordpress-develop/blob/6.2/src/wp-includes/functions.php#L3328-L3448

Also, the wp-includes/functions.php link is broken and there is a formatting issue with theupload_mimesfilter!:

Suggested Fix

Update the default list to:

jpg jpeg png gif webp mov avi mpg 3gp 3g2 midi mid pdf doc ppt odt pptx docx pps ppsx xls xlsx key mp3 ogg flac m4a wav mp4 m4v webm ogv flv

Correct the broken wp-includes/functions.php link to point to Repo/Trac.

Fix the spacing around

... theupload_mimesfilter! ...

zzap commented 1 year ago

Heads up @WordPress/docs-issues-coordinators, we have a new issue open. Time to use 'em labels.