search

WordPress / Documentation-Issue-Tracker

Issue Tracker for the WordPress Documentation team.
https://make.wordpress.org/docs/
Other
84 stars 41 forks source link

Replacing hard coded style tags with wp_add_inline_style #1168

Open abhansnuk opened 1 year ago

abhansnuk commented 1 year ago

Trac ticket: https://core.trac.wordpress.org/ticket/58775

Keyword on ticket: needs-dev-note

Writer: Jonny Harris 2023/10/12 Received Dev note draft - google doc

github-actions[bot] commented 1 year ago

Heads up @WordPress/docs-issues-coordinators, we have a new issue open. Time to use 'em labels.

codente commented 1 year ago

I've reviewed the draft also and it looks good from here!

bph commented 1 year ago

Converted to make Blog; Public Preview link: https://make.wordpress.org/core/?p=109034&preview=1&_ppp=d4d6b66275

bph commented 1 year ago

Little wrinkle,

Needs an author change and I couldn't make @spacedmonkey show in the drop-down list...

nalininsbs commented 1 year ago

Noting discussion on this in core-performance. No one else with editor access could do this either, eventhough Jonny's username is showing as Editor in users. This may be a meta bug as happened with other authors yesterday too.

codente commented 1 year ago

I can't change labels or anything but this one has been published so could be updated to reflect that it's done, I think? https://make.wordpress.org/core/2023/10/17/replacing-hard-coded-style-tags-with-wp_add_inline_style/

nalininsbs commented 1 year ago

Edit thank you to Weston Ruter and Abha.

Published. Waiting for information from performance for Field Guide.