WordPress / Documentation-Issue-Tracker

Issue Tracker for the WordPress Documentation team.
https://make.wordpress.org/docs/
Other
77 stars 39 forks source link

[Theme Handbook Overhaul] Advanced Topics > Publishing Themes #1409

Closed justintadlock closed 7 months ago

justintadlock commented 8 months ago

This ticket is a part of https://github.com/WordPress/Documentation-Issue-Tracker/issues/816 and will be used to add a new doc titled "Publishing Themes" under Chapter 7: Advanced Topics.

This will be drafted in this Google Doc: https://docs.google.com/document/d/1yeM0r9NaA59_zySjaX-wfFEB_yoFL-3bVHuEURBEWZk/edit?usp=sharing

@alexdeborba will be working on this draft. 🎉

github-actions[bot] commented 8 months ago

Heads up @kafleg @carolinan @TeBenachi - the "themes" label was applied to this issue.

github-actions[bot] commented 8 months ago

Heads up @WordPress/docs-issues-coordinators, we have a new issue open. Time to use 'em labels.

alexdeborba commented 8 months ago

I will be collaborating while writing this document.

alexdeborba commented 8 months ago

The document is now finished and ready for review.

justintadlock commented 8 months ago

@alexdeborba - I've given this an editing pass. For the most part, I just changed some stylistic stuff to match the doc standards and added some additional links. It's really good. 👍

I'm happy to approve my "suggestions" in the Google Doc since I have editing access, but I wanted to leave them for you in case you wanted to review them first.

@kafleg - You may also want to give it a review or wait until we prep the entire Advanced Topics chapter for publishing (I think this could happen within the next week or so).

alexdeborba commented 8 months ago

@justintadlock I particularly value your approach of providing suggestions instead of directly applying changes. This enables me to gain a deeper understanding of the desired styling and formatting, allowing me to internalize these principles and maintain consistency in future documents.

@kafleg After implementing all suggestions and conducting a thorough review for omissions, I consider the document complete. Please feel free to offer any further revisions.

kafleg commented 7 months ago

I added my comments in the Doc. Please check it.

justintadlock commented 7 months ago

@kafleg - I made some more edits to this one, simplifying some of the language and cutting a few bits. The most up-to-date version is drafted in the handbook: https://developer.wordpress.org/wp-admin/post.php?post=152151&action=edit

It should be good to publish now. @alexdeborba addressed both mine and your feedback.

kafleg commented 7 months ago

Looks good to me. Please publish it.

justintadlock commented 7 months ago

This is now published here: https://developer.wordpress.org/themes/advanced-topics/publishing-themes/