WordPress / Documentation-Issue-Tracker

Issue Tracker for the WordPress Documentation team.
https://make.wordpress.org/docs/
Other
84 stars 41 forks source link

Incorrect Code Example in admin_action_{action} Hook Documentation #1802

Open PARTHVATALIYA opened 3 days ago

PARTHVATALIYA commented 3 days ago

Issue Description

The code example provided in the admin_action_{action} hook documentation does not match the actual implementation found in the WordPress core files.

URL of the Page with the Issue

https://developer.wordpress.org/reference/hooks/admin_action__requestaction

Section of Page with the issue

https://developer.wordpress.org/reference/hooks/admin_action__requestaction/#source

Why is this a problem?

The inaccurate code example can mislead developers into implementing the hook incorrectly, potentially causing issues in their WordPress sites or plugins. Clear and accurate examples are essential for helping developers understand how to use hooks properly.

Suggested Fix

Replace the current code example with the accurate implementation as found in wp-admin/admin.php between lines 408-420. Below is the correct code:

if ( ! empty( $_REQUEST['action'] ) ) {
    $action = $_REQUEST['action'];

    /**
     * Fires when an 'action' request variable is sent.
     *
     * The dynamic portion of the hook name, `$action`, refers to
     * the action derived from the `GET` or `POST` request.
     *
     * @since 2.6.0
     */
    do_action( "admin_action_{$action}" );
}
github-actions[bot] commented 3 days ago

Heads up @WordPress/docs-issues-coordinators, we have a new issue open. Time to use 'em labels.