WordPress / Documentation-Issue-Tracker

Issue Tracker for the WordPress Documentation team.
https://make.wordpress.org/docs/
Other
84 stars 41 forks source link

#57375 #57557 Add move_dir() function #671

Open zzap opened 1 year ago

zzap commented 1 year ago

https://core.trac.wordpress.org/ticket/57375

Dev Note in progress: https://make.wordpress.org/core/?p=102401&preview=1&_ppp=a366238db0

Related: https://core.trac.wordpress.org/ticket/57557

zzap commented 1 year ago

Heads up @WordPress/docs-issues-coordinators, we have a new issue open. Time to use 'em labels.

zzap commented 1 year ago

Hi @costdev, thank you so much for writing the Dev note. I'd say we only miss a few things right now:

The last one will be added once the Dev note is published. Would you mind adding the first two links to the note? Thanks

costdev commented 1 year ago

Hi @zzap! I have updated the draft to include the two ticket numbers 🙂

zzap commented 1 year ago

Thank you so much @costdev ❤

abhansnuk commented 1 year ago

Second review completed. Thanks @zzap and @costdev .

It just needs an excerpt needed, if it does not have this already which improves the summary which appears when it is added to the Field Guide, and what people see in search.

If it needs props added at the end, I understand we are italicising these and right justifying them.

This function will be a useful improvement for users.

costdev commented 1 year ago

@abhansnuk Does this work as an excerpt? (52 words)

Move a directory quickly and easily, with a choice of whether to overwrite an existing directory. Fall back to copy_dir() should moving fail, and receive informative error messages should something go wrong along the way. Save on time, memory and diskspace usage. Includes recursive OPcache invalidation for PHP files inside the directory.

abhansnuk commented 1 year ago

Hello @costdev , I have tested it in Google preview and on mobile. It helps to include a reference to WordPress 6.2 in the excerpt, where there is space as the title does not give that information.

So perhaps incorporating this, or an even shorter variation: 'Move a directory quick and easily in WordPress 6.2. Fall back to copy_dir() if moving fails, and get useful informative error messages if anything goes wrong. Save on time, memory and disk space usage.'

costdev commented 1 year ago

@abhansnuk The shorter version sounds good to me!

abhansnuk commented 1 year ago

Excerpt and props copied over. Ready to publish.