search

WordPress / Learn

WordPress.org Learn - The canonical source for the code and content behind https://learn.WordPress.org
263 stars 89 forks source link

Test Playground Block on Learn WordPress. #2352

Open jonathanbossenger opened 5 months ago

jonathanbossenger commented 5 months ago

Once #2264 is merged and deployed, let's create a test/example lesson in preview mode, and test the playground block.

Test page

You can test the playground block in both default and code view mode at the following URL

Issues list

jonathanbossenger commented 3 months ago

Test page: https://learn.wordpress.org/test/wordpress-playground-block-plugin-test-page/

brandonpayton commented 1 month ago

Hi @jonathanbossenger, a new version of the Playground block (interactive-code-block) has been released (v0.2.11) and contains updates to address the following issues:

Most of these issues are left open until we can confirm they are indeed fixed.

Today, the remaining issues are:

jonathanbossenger commented 1 month ago

Thanks @brandonpayton

@alexstine I can confirm that this version of the playground block is active on the Learn site, and we can test this on the test page.

Do you have some time in the coming weeks to test the issues that @brandonpayton has linked in the comment above?

alexstine commented 1 month ago

@brandonpayton Two more small issues.

  1. Could you please hide the arrow icon to screen readers for the Open in New Tab button? Looks like you are using the :after selector to add it so you could either add it in a span with aria-hidden or simply add aria-label="Open in New Tab" to the button.
  2. For the read-only files, awesome that the button communicates that but the input field does not. Think you can open an upstream PR to get aria-readonly or HTML5 readonly support?

This has come a long way, thanks for the hard work on it.

brandonpayton commented 1 month ago

@alexstine, thanks for your review and continued feedback. I'm glad this is trending in the right direction!

The two new issues are logged, and I'm working on them next:

jonathanbossenger commented 1 month ago

Thanks @brandonpayton

brandonpayton commented 1 month ago

Hi @jonathanbossenger, a new version of the Playground block (interactive-code-block) has been released (v0.2.12) and contains updates to address the following issues:

These issues are left open until we can confirm they are indeed fixed.

Today, with the exception of the styling issues reported here, the remaining issues are:

jonathanbossenger commented 1 month ago

Thanks @brandonpayton

@alexstine I can confirm that this new version has been deployed to learn.wordpress.org, which you can test on the test page.

brandonpayton commented 1 month ago

Hi @jonathanbossenger, a new version of the Playground block (interactive-code-block) has been released (v0.2.13), and it (along with v0.2.12) contains updates to address the following issues:

These issues are left open until we can confirm they are indeed fixed.

Today, the remaining a11y issue is:

I'm not sure if it is a blocker, but I haven't been able to figure out a good fix for it yet.

jonathanbossenger commented 1 month ago

Thanks @brandonpayton

@alexstine I can confirm that the new version of the playground block has been deployed to learn.wordpress.org. It would be greatly appreciated if you have time to test it.

The test page is still at the following URL: https://learn.wordpress.org/test/wordpress-playground-block-plugin-test-page/

brandonpayton commented 1 month ago

Hi @jonathanbossenger, version v0.2.14 is now released which additionally contains a fix for

jonathanbossenger commented 1 month ago

Thank you @brandonpayton.

I'm going to raise this to the training team in our weekly meeting this week, to see if we can get some more help with testing, so we can confirm that everything works as expected.

jonathanbossenger commented 1 month ago

@brandonpayton I've created a consolidated list of open issues related to the playground block in the main description of this issue. Could you verify that a) I've gathered all the relevant issues into that list and b) only the open issues need testing?

I am reaching out to folks to help with testing, so I want to make it easier for them to see what needs testing.

joedolson commented 4 weeks ago

I'll go through this next week.

jonathanbossenger commented 4 weeks ago

Thanks @joedolson

brandonpayton commented 3 weeks ago

@brandonpayton I've created a consolidated list of open issues related to the playground block in the main description of this issue. Could you verify that a) I've gathered all the relevant issues into that list and b) only the open issues need testing?

I am reaching out to folks to help with testing, so I want to make it easier for them to see what needs testing.

@jonathanbossenger

That list looks good, except that we could add: https://github.com/WordPress/playground-tools/issues/343

I'm not sure if it is a blocker.

brandonpayton commented 3 weeks ago

@jonathanbossenger We have released v0.2.15 of the Playground block (interactive-code-block) that contains a fix for https://github.com/WordPress/playground-tools/issues/343. That issue can be added to the list above.

Thank you!

jonathanbossenger commented 3 weeks ago

Done, thanks @brandonpayton.

@joedolson it might take a day or so for the updated block to be deployed to Learn.WordPress.org for you to be able to test https://github.com/WordPress/playground-tools/issues/343

joedolson commented 3 weeks ago

This is still on my radar; but I had a client project abruptly transition from a Sept. 9 launch date to an Aug 23 launch date for emergent reasons, and it's pretty much trashed my week.

brandonpayton commented 3 weeks ago

Thank you, @joedolson. Good luck with everything!

joedolson commented 1 week ago

Adding a new comment so I can check these off as I confirm them.

joedolson commented 1 week ago

Almost everything is done here, except that I think there is a significant improvement that could be made on https://github.com/WordPress/playground-tools/issues/290. I'd recommend completing that recommendation, but then I think this is good.

brandonpayton commented 1 week ago

Thanks for your help, @joedolson!

@jonathanbossenger the remaining work is on my radar, and I plan to look at it next, in the next couple of days.

cc @adamziel

brandonpayton commented 1 week ago

@jonathanbossenger, we've released v0.2.16 of the interactive-code-block plugin with some changes in response to @joedolson's comments here.

The changes add:

joedolson commented 6 days ago

Just let me know when that's available for testing and I'll check it out!