search

WordPress / Learn

WordPress.org Learn - The canonical source for the code and content behind https://learn.WordPress.org
244 stars 87 forks source link

New Theme: Workshop card bottom not consistent. #2619

Closed StevenDufresne closed 1 week ago

StevenDufresne commented 3 weeks ago

Description

On the homepage, I see workshops with differing title lengths. The bottom part of the card is inconsistent. I would expect the bottom to not float up for shorter titles.

Screenshot

Screenshot 2024-07-05 at 9 34 33 AM
adamwoodnz commented 2 weeks ago

Noting that this isn't the final state for these cards, they are intended to be like the other cards but we don't have featured image support yet. We could use the fallback featured image like other cards.

adamwoodnz commented 2 weeks ago

Noting that this isn't the final state for these cards, they are intended to be like the other cards but we don't have featured image support yet. We could use the fallback featured image like other cards.

@WordPress/meta-design what do you think about doing this? It would mean that the layout for all cards would be consistent, but these online workshop cards would have the fallback image until we work out the featured image support, which so far has proved challenging.

Alternatively we could leave them as is and push the details to the bottom.

jasmussen commented 2 weeks ago

Can we do a min-height on the cards that is optimized for 3 lines of text, and then do a space-between stack layout where the title is top aligned and the metadata is bottom aligned?

adamwoodnz commented 1 week ago

Alternatively we could leave them as is and push the details to the bottom.

Can we do a min-height on the cards that is optimized for 3 lines of text, and then do a space-between stack layout where the title is top aligned and the metadata is bottom aligned?

👍 I think we're describing the same thing; and I'm guessing you mean 3 lines of text for the title only.

jasmussen commented 1 week ago

Yes! Thanks.