Closed renintw closed 2 months ago
This looks good, thank you!
The one thing I don't understand why a true/false question would need to be graded manually by a teacher. I thought that was only for open-ended questions? Or is it for any type of question, when the quiz is not set to be automatically graded?
Everything looks great.
- Does the quiz grade on the lesson page also need to be removed? @fcoveram
I will defer this question to @kathrynwp. If the info displayed is relevant to learners, then I will keep it.
Does the quiz grade on the lesson page also need to be removed?
I will defer this question to @kathrynwp. If the info displayed is relevant to learners, then I will keep it.
Is the reason you're suggesting removing it because it will always be 0% until the quiz is graded by the instructor? If that's the case, then I think it should be removed as it's very confusing to see 0% for a quiz that hasn't been graded yet.
If this is a "real" grade then I think we can keep it.
cc @westnz for input as well as I will be AFK over the next week and don't want to hold this up.
At this stage, we must remind ourselves to select 'Auto-grade' as we don't have any assessments that require an instructor to grade them.
Is the reason you're suggesting removing it because it will always be 0% until the quiz is graded by the instructor? If that's the case, then I think it should be removed as it's very confusing to see 0% for a quiz that hasn't been graded yet.
If this is a "real" grade then I think we can keep it.
Agreed, if the real grade was 'auto-graded'.
The one thing I don't understand why a true/false question would need to be graded manually by a teacher. I thought that was only for open-ended questions? Or is it for any type of question, when the quiz is not set to be automatically graded?
That's right, as long as the switch here for a quiz isn't turned on, all questions will require the teacher to grade them. This part needs to be modified on the Sensei plugin side.
Is the reason you're suggesting removing it because it will always be 0% until the quiz is graded by the instructor? If that's the case, then I think it should be removed as it's very confusing to see 0% for a quiz that hasn't been graded yet.
If this is a "real" grade then I think we can keep it.
It's a real grade that will show up only after a quiz is completed and graded. The reason I asked was to align with the pending-graded notice. The 'Awaiting grade' text has been removed there. I'm currently following the feedback provided and keeping 'Your Grade' for now. If it needs to be removed, please let me know. Thanks. @westnz
Before | After |
---|---|
@thetinyl, could you suggest a copy for the two messages below? Thanks!
Here's the flow:
https://github.com/user-attachments/assets/2d092b06-b539-4c85-a9bb-6fb27fc46749
Thanks, Ren. Sounds good.
I had a chat with @kathrynwp about this and my understanding for this flow is:
Given that there is no grading process (and there won't be one), I think it makes sense to frame the language here around these being "ungraded quizzes". I'll follow up later/tomorrow with an actual copy suggestion, but just wanted to note this alternate direction in case others have other thoughts.
@thetinyl, could you suggest a copy for the two messages below?
@renintw I think we're going to need to update the copy on the first screen as well (see screenshot below), since it still makes a reference to grading.
Here's some suggested copy for each:
Quiz submission message
Well done! You completed the quiz.
Quiz completed message
QUIZ COMPLETED This quiz won’t be graded. If you found the questions easy, you likely have a good understanding of the lesson.
View quiz message
This is an ungraded quiz. Use it to check your comfort level with what you’ve learned.
Thanks @thetinyl, there are the updated screenshots.
Thanks @renintw. I just have one minor copy edit for the following message:
Let's revise to read:
This quiz won’t be graded. If you found the questions easy, you likely understand the lesson well.
Thanks @thetinyl, I updated the design file to reflect these copy changes
Resolves #2686
This PR replaces the pending text to align with the design as well as adding required notices. Also updates quiz action styles and the success icon image.
Screencast
https://github.com/user-attachments/assets/5cb567f2-121e-444e-a932-23ed975f135c
@kathrynwp, I implemented @fcoveram designs first as I think they make sense. Above is the screencast of the flow based on the design. The differences compared to the original are in the screenshots below.
The flow is generally as shown. And after the teacher finishes grading, It will return to looking the same as the others:
TODO
Update the copy
Does the quiz grade on the lesson page also need to be removed? @fcoveram