WordPress / Learn

WordPress.org Learn - The canonical source for the code and content behind https://learn.WordPress.org
277 stars 100 forks source link

Malicious/Suspicious links in the handbook #2954

Closed jennydupuy closed 1 month ago

jennydupuy commented 1 month ago

In the page Translating content, I detected these two links as malicious:

1.DownSub (https://downsub.com/) 2.YouTube Subtitle Download Helper(https://chromewebstore.google.com/detail/youtube-subtitle-download/dpmmcccjdcgdjnlnicicdbnlmohhpagf)

see the reports of VirusTotal https://www.virustotal.com/gui/url/a1e76c7f15db4c4627bbfa08161f3a4d883cda5fa99e07c5ce2f9f15464abbe4 https://www.virustotal.com/gui/url/559cad202e4cd61544e63ff1d28b36f94c90d2e65b6f84f09535318cb0a00597

I hope this issue will help.

kaitohm commented 1 month ago

Thanks for the report.

For now, I've replaced the following text in the handbook

Download the automatically translated video captions from YouTube using free tools such as DownSub or YouTube Subtitle Download Helper. Clean these up as necessary.

with

This needs translating.

I had a look online for other free software and couldn't find anything that downloads the auto-translated captions. We might have to rely on manual translation methods for now.

jennydupuy commented 1 month ago

I’ve found this tool: https://www.downloadyoutubesubtitles.com/

jennydupuy commented 1 month ago

But the proposed formats are: SRT or VTT or TXT.

kaitohm commented 1 month ago

That tool looks great! I've updated the handbook to recommend that one.

jennydupuy commented 1 month ago

Be careful, the online tool https://www.downloadyoutubesubtitles.com/ is also malicious. Sorry.

kaitohm commented 1 month ago

https://www.virustotal.com/gui/url/71641ca4b12fa4336721ce717f28f7c08c02a3cf018eecece02d2e27fdc119a4/detection doesn't show that https://www.downloadyoutubesubtitles.com/ is malicious. How did you find that, @jennydupuy ?

jennydupuy commented 1 month ago

Yes VirusTotal don’t indicated this as malicious, but when I click on a button to download SRT file another tab opens with ads, setup Opera program or porn content. I have send a message to the site yesterday to let them know.

I have found a tool named 4k Video Downloader+ which allow you to download SRT file in the desired language. https://www.4kdownload.com/fr/downloads/9# In the free version, you can do 10 downloads by day. I think it's enough for our purposes.

kaitohm commented 1 month ago

Oh no! Thanks for catching that.

I've further updated the handbook page to now direct folks to use 4K Video Downloader Plus. How does this look now?

jennydupuy commented 1 month ago

It’s ok but you can use plural form for "subtitle language" because we can select several languages in same time. Image

For me, two steps are missing:

With this tool: https://converts.me/tools/conversion/subtitle/all we can edit the code of TTML file to modify the language tag before download it.

kaitohm commented 1 month ago

Hi @jennydupuy , Thanks for all the input.

I've updated the handbook page applying your suggestions.

I just didn't understand this part of your comment.

convert the translated SRT into txt, so as to have most of the text below the video, which then needs to be re-formatted and paragraph headings added.

Could you explain this feedback to me once more, based on the revisions I've applied? Thanks 🙇‍♂

jennydupuy commented 1 month ago

Hi @kaitohm

The text below the video under the heading “Transcript” is the same as the video's subtitles, only the presentation is different. See this screenshot. Image

So you can transform the SRT file to show only the text (= convert it to TXT) that corresponds to the transcript, and add paragraph headings to this text in the right places (text highlited in pale red on the screenshot).

In the handbook, in the step 3 in paragraph "Learning Pathway Courses" replace the strikethrough text Image

Then, the paragraph could be like this:

  1. Each lesson will have up to 5 components that need translating. Include all these in the Google Document from step 2 except the captions. The lesson title – This needs translating. The captions on the video – This needs be downloaded and corrected. See how to do this in the tip below. The transcript in the lesson – It is equivalent to captions text, but is presented differently with headings. See the tip below. The headers throughout the transcript – Add translated headers to match the English transcript. The quiz – Some lessons will have a quiz. Translate the questions and options in the same Google Document as above.

And the tip, coulb be like this (new text in italic):

To modify the auto-generated captions on YouTube and generate the text of the transcript, then follow these steps.

  1. Download the automatically translated video captions from YouTube using free tools such as 4K Video Downloder Plus.
  2. With 4K Video Downloader Plus, you can download translated captions by selecting the subtitle language(s) from the Download Video menu.
  3. Edit the captions in a text editor. Don’t remove the time markers.
  4. Convert the caption file to the TTML file format using https://converts.me/tools/conversion/subtitle/all.
  5. On line 2 of the TTML output, replace xml:lang=“en” with xml:lang=“NEW_LANGUAGE_CODE”, where NEW_LANGUAGE_CODE is the two letter language code of the language the captions have been translated into.
  6. Download the TTML file. _7. With the same tool, convert also the caption file(s) to TXT file format using https://converts.me/tools/conversion/subtitle/all.
  7. Download the TXT file.
  8. Copy the content of TXT file to the Google Document and add the headers at the right places._
  9. Compress your caption file(s) (translated SRT and TTML) as a ZIP file and upload it to the GitHub issue.

Note that the translated SRT file can used on YouTube, the translated TTML file is used on wordpress.tv, when the reviewer has validated them.

I hope that my proposition seems more clear.

kaitohm commented 1 month ago

This is wonderful, @jennydupuy . It makes total sense to me!

I've updated the handbook page with your recommendations, making some minor adjustments to wording etc.

I think this issue is good to close now. What do you think?

jennydupuy commented 1 month ago

@kaitohm yes we can close. I wanted to take part in today's meeting to explain this workflow and the tools, but I haven't yet reconnected to the Making WP slack. I hope this workflow suits the team.