Closed courtneyr-dev closed 4 weeks ago
Revise to include https://github.com/WordPress/gutenberg/issues/40061
https://github.com/WordPress/gutenberg/pull/40435 See also: https://make.wordpress.org/core/2022/04/28/whats-new-in-gutenberg-13-1-27-april/ Minor screenshot revision needed
Add how to unset: https://github.com/WordPress/gutenberg/pull/39564
Demonstrate how to add Duotone to theme.json https://github.com/WordPress/gutenberg/pull/43671
Link to Theme.json lesson plan
Theme.json lesson plan is not published yet - https://learn.wordpress.org/?post_type=lesson-plan&p=15349 We can link it later.
I want to contribute to this issue but I think I'm lost.. Has the lesson plan been published? What is left to do, exactly? (I'm an Editor)
@fikekomala, yes all the WP 6.1 release related changes are done. if you want to contribute to this issue, Please review it and comment your feedback here. The link to the lesson plan: https://learn.wordpress.org/lesson-plan/use-duotone-filters-to-change-color-effects/
I reviewed the lesson plan according to the workflow described in the 'how to'. Here's my feedback.
Thank you, @fikekomala for reviewing and suggesting. I have made changes according to your feedback. Can I ask, which tool you used to test the readability?
Anytime, @webtechpooja. I used this https://www.perrymarshall.com/grade/ from the 'How to Use the Review in Progress Column'.
Hi @webtechpooja, I'd love to review this doc to get my feet wet. My first comment is for the third sentence in the intro (description). That sentence is wordy and passive (tone).
The first color can be used for the shadows on the dark section and the second one which is a light color can be used for highlighting.
These kinds of sentences are harder to read.
Here's how I would rewrite that.
For example, you can use a dark color for shadows and a light color for highlighting.
Thanks, @marklchaves for your suggestion. I'll replace it. and please let me know anything else that can be improved.
Hey @webtechpooja,
Just some more thoughts for what they're worth 😉
I always do a grammar check with Grammarly premium. There are a few comma and passive voice fixes Grammarly suggests (see the attached screen grab).
I'd also tweak the Objective section because it mixes third-person and second-person sentences. The Lesson Plan Style Guide says, "Always write in second person ..."
And, I'd tweak the Prerequisite Skills section to make sure the intro sentence flows with the bullet points and the bullets have parallelism.
I'd be happy to make these changes. Just let me know.
Cheers!
@marklchaves, Thank you for your suggestion. Yes Please, you can suggest the changes. Please make sure the original context of sentences will not change and that improves overall readability.
Hey @webtechpooja,
Not sure how you wanted my suggestions, but here they are ;-)
participants
and your
in the originalAfter completing this lesson, you'll be able to:
Participants will get the most from this lesson if they:
Hope these help!
Cheers :-)
Thank you so much @marklchaves for all your suggestion. I'll update the lesson plans accordingly.
https://github.com/WordPress/gutenberg/pull/49838 6.3
Duotone styles are now generated using the WordPress Style Engine, meaning that CSS is generated as part of the block supports CSS — rather than inline.
Visuals: image of Duotone Styles interface
//assign
Hi @bsanevans, thanks for your interest in this issue!
If you have any questions, do not hesitate to ask them in our #training Slack channel.
Thank you for contributing!
//assign
Hey @nikonikobsan, this issue is already assigned to @bsanevans.
A Faculty Administrator can also add you to the list of assignees or swap you with the current assignee. Or you can take a look at other unassigned issues we have.
https://learn.wordpress.org/lesson-plan/use-duotone-filters-to-change-color-effects/
Topic Description
Include how to apply duotone filters, as well as how to add duotone settings in Global Styles and Theme.json
Related Resources
Links to related content on Learn, HelpHub, DevHub, GitHub Gutenberg Issues, DevNotes, etc.
Guidelines
Review the team guidelines
Development Checklist:
Repo Structure and Lesson Plan Template
Description
Objectives
After completing this lesson, participants will be able to:
Target Audience
Who is this lesson intended for? What interests/skills would they bring? Put an "x" in the brackets for all that apply.
Experience Level
How much experience would a participant need to get the most from this lesson? Put an "x" in the brackets for all that apply.
Type of Instruction
Which strategies will be used for this lesson plan? Put an "x" in the brackets for all that apply.
Time Estimate (Duration)
How long will it take to present this lesson? Put an "x" in the brackets for the one that applies.
Prerequisite Skills
Participants will get the most from this lesson if they have familiarity with:
Readiness Questions
Slides
Materials Needed
Notes for the Presenter
Lesson Outline
Exercises
Exercise name
Short description of what the exercise does and what skills or knowledge it reinforces.
Assessment
There should be one assement item (or more) for each objective listed above. Each assessment item should support an objective; there should be none that don't.
Write out the question.
Answer: 3. Correct answer
Additional Resources
Example Lesson
Section Heading for Example Lesson
Lesson Wrap Up
Follow with the Exercises and Assessment outlined above.