search

WordPress / Requests

Requests for PHP is a humble HTTP request library. It simplifies how you interact with other sites and takes away all your worries.
https://requests.ryanmccue.info/
Other
3.57k stars 498 forks source link

Include request data in exceptions #272

Open davidfavor opened 7 years ago

davidfavor commented 7 years ago

https://core.trac.wordpress.org/ticket/40266 documents what seems a bug.

In some cases, hostnames are included in errors + sometimes they're missing.

Trying to debug problems with missing hostnames requires, hacking up code, injecting manual debug logic in various places.

An ugly solution.

Request that all errors returned by the Requests library always include a hostname for the related error.

davidfavor commented 7 years ago

This issue still requires resolution.

As it stands, some errors contain no URL which makes debugging complex.

davidfavor commented 7 years ago

This issue still requires resolution.

As it stands, some errors contain no URL which makes debugging complex.

davidfavor commented 7 years ago

This issue still requires resolution.

As it stands, some errors contain no URL which makes debugging complex.

rmccue commented 7 years ago

@davidfavor Please don't continually comment on this issue. You're welcome to submit a pull request to fix this.

davidfavor commented 7 years ago

Be far better if the developers provided a fix.

This problem effects every WordPress site.

davidfavor commented 7 years ago

Finally tracked down bug.

Problem relates to new systemd-resolved code used now on Distros making use of the horribly broken systemd subsystem (my opinion).

The systemd-resolved subsystem is incredibly slow.

Moving full explanation to new WordPress ticket.