search

WordPress / Requests

Requests for PHP is a humble HTTP request library. It simplifies how you interact with other sites and takes away all your worries.
https://requests.ryanmccue.info/
Other
3.57k stars 497 forks source link

GH Actions/update website: update for new "create pull request" action runner version #805

Closed jrfnl closed 1 year ago

jrfnl commented 1 year ago
  1. Looks like GitHub recently made some changes in how the GITHUB_TOKEN behaves when a workflow is triggered by a PR created via Dependabot. Due to this change, the PR which this workflow is trying to create is blocked, which is what's causing the build failure on PR #804. By adding these explicit permissions, the workflow should be able to create the "website update" PR, even when the workflow is triggered by a Dependabot PR. Refs:
  2. In version 5 of the peter-evans/create-pull-request action runner, the original branch will be checked out after the PR creation has finished. This is different from version 4, which left the PR branch checked out. As the test build of the GH Pages site should be run on the PR branch (as otherwise we would be testing the already deployed gh-pages branch), we need to add an extra step to re-checkout the PR branch after the PR has been created and before running the GH Pages build test.

Once this PR has been merged, PR #804 should be rebased and :fingers_crossed: the workflow build should pass.

👉🏻 Even though this PR is pulled against develop, I'm milestoning it for the next 2.0.x release as this change should probably be backported.

jrfnl commented 1 year ago

Note: for checking out the branch, I've currently used the checkout action runner. As the branch is available locally within the workflow workspace, we could use a plain git command instead. Thoughts/preference ?