Closed nosilver4u closed 9 months ago
@nosilver4u Aside from the fundamental question of whether this is a valid "fix" (in contrast to the user doing it wrong), a PR will not be reviewed or even considered without unit tests documenting the use case. So without tests, this PR will be closed.
I missed an update to the parse() method anyway, so I need to create a new pull request with both changes. Regarding tests, I had wondered about that, so I'll see what I can figure out on that end.
Fixes #845 so that an exception isn't thrown for legitimate numeric cookie names.
There are two changes:
Pull Request Type
This is a:
Context
Currently, multiple plugins, and possibly even WP core are throwing errors if someone has a cookie with a numeric name. Would love to see this issue go away, so that folks don't have to resort to deleting cookies in the dev tools of their browser.
Quality assurance