In the next major version of Requests (v3.x), we plan on making more classes final, to simplify the process of keeping in line with the accelerating pace of PHP changes without always incurring the overhead of a BC break.
The v3.x release is still far away on the horizon, but we'd like to get the discussion started as early as possible on this to give affected people a heads-up and hopefully gather more feedback before we pull the trigger on this.
If you can provide any feedback on why or why not some of these classes should be made final, please add a comment on this issue. We're happy to consider valid use cases and make sure we can respect any reasonable extension scenarios.
The following classes are UNDER CONSIDERATION to be made final
We think these are not currently being extended, and making them final will simplify the long-term maintenance work on this package.
Make final?
Class name in v2.x
Class name in v1.x
Notes
no
WpOrg\Requests\Requests
Requests
Keep extensible as last-resort fallback
yes
WpOrg\Requests\Cookie
Requests_Cookie
Direct coupling in WpOrg\Requests\Cookie\Jar
yes
WpOrg\Requests\IdnaEncoder
Requests_IDNAEncoder
Direct coupling in WpOrg\Requests\Requests & WpOrg\Requests\Cookie
yes
WpOrg\Requests\Iri
Requests_IRI
Direct coupling in WpOrg\Requests\Requests & WpOrg\Requests\Cookie\Jar & WpOrg\Requests\Session
yes
WpOrg\Requests\Cookie\Jar
Requests_Cookie_Jar
Direct coupling in WpOrg\Requests\Requests & WpOrg\Requests\Response & WpOrg\Requests\Session
yes
WpOrg\Requests\Response\Headers
Requests_Response_Headers
Direct coupling in WpOrg\Requests\Response
The following classes will NOT be made final
These classes are known to be already extended at this time and will remain as-is for that reason.
In the next major version of Requests (v3.x), we plan on making more classes
final, to simplify the process of keeping in line with the accelerating pace of PHP changes without always incurring the overhead of a BC break.The v3.x release is still far away on the horizon, but we'd like to get the discussion started as early as possible on this to give affected people a heads-up and hopefully gather more feedback before we pull the trigger on this.
If you can provide any feedback on why or why not some of these classes should be made
final, please add a comment on this issue. We're happy to consider valid use cases and make sure we can respect any reasonable extension scenarios.The following classes are UNDER CONSIDERATION to be made
finalWe think these are not currently being extended, and making them
finalwill simplify the long-term maintenance work on this package.WpOrg\Requests\RequestsRequestsWpOrg\Requests\CookieRequests_CookieWpOrg\Requests\Cookie\JarWpOrg\Requests\IdnaEncoderRequests_IDNAEncoderWpOrg\Requests\Requests&WpOrg\Requests\CookieWpOrg\Requests\IriRequests_IRIWpOrg\Requests\Requests&WpOrg\Requests\Cookie\Jar&WpOrg\Requests\SessionWpOrg\Requests\Cookie\JarRequests_Cookie_JarWpOrg\Requests\Requests&WpOrg\Requests\Response&WpOrg\Requests\SessionWpOrg\Requests\Response\HeadersRequests_Response_HeadersWpOrg\Requests\ResponseThe following classes will NOT be made
finalThese classes are known to be already extended at this time and will remain as-is for that reason.
WpOrg\Requests\ExceptionRequests_ExceptionWpOrg\Requests\HooksRequests_HookWpOrg\Requests\ResponseRequests_ResponseWpOrg\Requests\SessionRequests_SessionWpOrg\Requests\Auth\BasicRequests_Auth_BasicWpOrg\Requests\Utility\CaseInsensitiveDictionaryRequests_Utility_CaseInsensitiveDictionaryWpOrg\Requests\Exception\HttpRequests_Exception_HTTPWpOrg\Requests\Exception\TransportRequests_Exception_Transport