WordPress / Requests

Requests for PHP is a humble HTTP request library. It simplifies how you interact with other sites and takes away all your worries.
https://requests.ryanmccue.info/
Other
3.57k stars 498 forks source link

CS/QA: various minor fixes #881

Closed jrfnl closed 3 months ago

jrfnl commented 4 months ago

CS: minor tweak

Response\Headers\FlattenTest: minor improvement to data provider

... for readability.

Docs: favour generic type hint syntax over array type hint syntax

... for higher specificity and improved compatibility with tools like PHPStan.

Docs: various minor tweaks

Transport/BaseTestCase: make child class expectation explicit

The BaseTestCase class expects a child class to declare a $transport property. This makes that expectation explicit.

Response/Headers/GetIteratorTest: minor fix

The WpOrg\Requests\Exception::__construct() method expects a minimum of 2 (required) parameters.

While this default case is basically impossible to be hit, the exception creation should still be correct.

Cookie/ParseTest: fix an incorrect condition

As the $expected_attributes and $expected_flags variables are optional parameters, these will always be set. However, they may not be set to an array, which is what this condition should protect against.