PHP 8.3 Deprecation Notice: trim(): Passing null to parameter #1 ($string)

[Ti3Et0s]

Description

When using WPCS with PHP 8.3, the I18n and PrefixAllGlobals sniffs are causing deprecation notices due to trim() being called with null values.

Error Message

trim(): Passing null to parameter #1 ($string) of type string is deprecated

The error occurs in:

• /WordPress/Sniffs/WP/I18nSniff.php on line 194
• /WordPress/Sniffs/NamingConventions/PrefixAllGlobalsSniff.php on line 280

Environment

• PHP Version: 8.3.11
• WPCS Version: 2.3.0
• Project: Working with _s (Underscores) WordPress starter theme

Impact

This affects all PHP files being checked by these sniffs, making it difficult to use WPCS with PHP 8.3. The error prevents proper code analysis as the checking is aborted when the deprecation notice is encountered.

Temporary Workaround

Currently using a local PHPCS configuration that excludes these sniffs to allow development to continue, but this means losing important WordPress-specific checks.

Suggested Solution

Update the relevant sniffs to ensure trim() is only called on string values, possibly by adding type checking before the trim() calls.

[jrfnl]

Closing as invalid. This was fixed years ago and included in the WPCS 3.0.0 release.