search

WordPress / better-code-editing

[✅ Merged into 4.9-alpha] Better Code Editing WordPress plugin
https://wordpress.org/plugins/better-code-editing/
37 stars 16 forks source link

Use npm to import CodeMirror instead of submodule #7

Closed WraithKenny closed 7 years ago

WraithKenny commented 7 years ago

Since you require npm building CodeMirror anyway, maybe it'd make sense to use npm to install it instead? Or even a nice Gulp script to concatenate, minify, and move into a non-modules location?

WraithKenny commented 7 years ago

Or is this because you need to bundle the source code for GPL reasons?

westonruter commented 7 years ago

@WraithKenny how's #23 look?

WraithKenny commented 7 years ago

I can test it out tomorrow, but sounds good to me :-)