Closed samikeijonen closed 6 years ago
Also when help section is opened if the CSS is empty, value should be aria-expanded="true"
at that point.
@samikeijonen I think you may be looking at the wrong element. Look at .customize-section-description
not .customize-pane-child
.
Upon load Customizer:
Upon clicking Close:
Whether or not .customize-pane-child
should be getting the same toggle of aria-expanded
would be an issue for core.
Ah ok, I try to open trac ticket for .customize-pane-child
aria-expanded
bug.
Haven't checked live, just looking at the screenshot above, seems to me aria-expanded
on a not-focusable div won't do anything useful. The toggle button needs to reflect the expandable panel state it relates to.
@westonruter Can you re-open this? When we checked ?-button in the Menu section for example, that button has correct aria-expanded="false"
and aria-expanded="true"
when toggling.
@samikeijonen please open a new defect Trac ticket. I just merged this plugin into trunk.
@samikeijonen I'm working on a core patch which includes the aria-expanded fix, will update this comment adding the Trac ticket number when I'm done.
Nice.
In ?-help-button (Additional CSS section) there is
aria-expanded="false"
. But it doesn't change toaria-expanded="true"
when opened and back toaria-expanded="false"
when closed.