search

WordPress / better-code-editing

[✅ Merged into 4.9-alpha] Better Code Editing WordPress plugin
https://wordpress.org/plugins/better-code-editing/
37 stars 16 forks source link

Keyboard focus when Help section is open #90

Closed samikeijonen closed 6 years ago

samikeijonen commented 6 years ago

I notices this keyboard navigation in Additional CSS.

  1. Help section is open.
  2. I'm inside CSS fields (writing CSS).
  3. I press Esc + Shift + Tab.
  4. My focus moves to ?-help-button.

In my opinion it should move to last focusable item in the help section (Close button in this case).

If the help section is closed, then focus should move to ?-help-button.

westonruter commented 6 years ago

Good point. The close button was added after the tab-precious logic was implemented so it is not being taken into account. Also I assumed the user would close the help description first, but clearly that's not the case.