WordPress / block-directory

Block library: Timeline and plan: https://make.wordpress.org/design/2019/04/26/block-library-installing-blocks-from-within-gutenberg/
28 stars 7 forks source link

Design Explorations: Error States #11

Open melchoyce opened 5 years ago

melchoyce commented 5 years ago

We need to figure out all the potential errors and where there can be points of failure:

Related: #8

melchoyce commented 5 years ago

If we can't preview the block for some reason, like a WordPress.org outage:

image

@ck3lee do you know if we have existing error strings for something like this? If not, we'll want to write one.

If the installation fails (but the block can preview):

image


Is there any other point in this flow that might produce an error?

melchoyce commented 5 years ago

Permissions

If you don't have administrative permissions (or any custom permission that allows installation of new plugins), let's show the existing message for search results:

boemedia commented 5 years ago

In the last case, is it possible to show the blocks but greyed out, with a message saying: "Your current role doesn't allow installing new blocks. Contact your website's administrator."

melchoyce commented 5 years ago

Maybe like:

image

karmatosed commented 5 years ago

I like that as an option over having greyed out. I feel if we showed greyed out blocks it could taunt the user.

ck-lee commented 5 years ago

do you know if we have existing error strings for something like this?

No, I couldn't find any existing error strings. I only found a couple that are generic and technical like The response is not a valid JSON response.. So, we might need to write them.

ck-lee commented 5 years ago

LGTM! I think the two scenarios: "can't preview the block" and "installation fails" should capture all the unexpected failure points. I will drop a comment here if I can think of anything else.

ck-lee commented 5 years ago

@melchoyce, I'm finding it very tricky to implement the actions in the notice bar. I am finding out more from the Gutenberg dev team now.

In case, it is a mission to add the actions like "Retry" or "Remove block", is it OK to remove them?

melchoyce commented 5 years ago

As long as we can add them to a later roadmap and follow up, I think it's okay to drop from the v1.

ck-lee commented 5 years ago

Thank you @melchoyce. Looks like we can do a "Retry". 😄

By default all "non-url actions" in the notice are rendered as buttons instead of links. I think it might be semantically more appropriate for a11y. But happy to re-style that as a link too.

Still a WIP. But here is what is looks like: screencast 2019-07-18 10-55-16

ck-lee commented 5 years ago

And for user without permission to install a block.

This is how it looks like:

screencast 2019-07-18 10-57-12

karmatosed commented 5 years ago

@melchoyce I wonder if the 'no blocks' could be an opportunity for a cute little graphic? Like a sad block. It's just an idea.

karmatosed commented 5 years ago

Just checking back on this, could it be in v1 to explore a little visual variation beyond text?

melchoyce commented 5 years ago

Should we explore this in Gutenberg core? We're hooking in to the core "no results" pattern.

karmatosed commented 5 years ago

Sure, I will make issue for this also.

melchoyce commented 5 years ago

Thanks, feel free to assign it to me.

karmatosed commented 5 years ago

@melchoyce https://github.com/WordPress/gutenberg/issues/17122 is where started that issue.