search

WordPress / community-themes

A collection of Block Themes built by the WordPress community.
70 stars 26 forks source link

Poetry: add alternative header part #179

Open adrianaleites opened 1 month ago

adrianaleites commented 1 month ago

Closes #174

adrianaleites commented 1 month ago

@MaggieCabrera Thanks for your review. I will try to address your comments here regarding the use of pixel values. I will add the spacingSizes in theme.json as in twentytwentyfour. And I will also convert the header-small template to be a pattern instead.

But I just notice that the page navigation is missing so maybe I will have to come up with a different solution for the small version of the header that can accomodate the navigation. There's no navigation in the original header pattern also. Or maybe It's supposed to be like that and this specific theme don't need a navigation in the header. What do you think?

MaggieCabrera commented 1 month ago

@MaggieCabrera Thanks for your review. I will try to address your comments here regarding the use of pixel values. I will add the spacingSizes in theme.json as in twentytwentyfour. And I will also convert the header-small template to be a pattern instead.

But I just notice that the page navigation is missing so maybe I will have to come up with a different solution for the small version of the header that can accomodate the navigation. There's no navigation in the original header pattern also. Or maybe It's supposed to be like that and this specific theme don't need a navigation in the header. What do you think?

I think we can make of it what we like. It makes sense to me that the focus of this kind of blog would be the post content, but if you click on internal pages you would like to go back to the home. Maybe we want our smaller header to just have the logo and the page title, removing the text "A collection of valuable thoughts...". In fact, now that I look at it, we should probably replace the image block for the site logo block and the other paragraph that we have for the "tagline" block instead.

github-actions[bot] commented 1 week ago

Preview changes

I've detected changes to the following themes in this PR: Poetry.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.