search

WordPress / community-themes

A collection of Block Themes built by the WordPress community.
80 stars 33 forks source link

Update Fix #189

Open iamsam2e opened 4 months ago

iamsam2e commented 4 months ago

Rebased from PR 145, to resolve issues for the 404 template as suggested my MC as well as resolving accidental push onto the existing #145 branch

this resolves both #144 and #145

github-actions[bot] commented 4 months ago

Preview changes

I've detected changes to the following themes in this PR: Archivist, Blue Note, Poetry, Term, Purr, Atlas.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

⚠️ Note: Child themes are dependent on their parent themes. You will have to install the parent theme as well for the preview to work correctly.

iamsam2e commented 3 months ago

Going to try to address this this week! :)

MaggieCabrera commented 3 months ago

I like the design and the text, but why are we making another header? do we think it's going to be one we want to reuse for other templates? Also, it might be time to move the parts that have text into a pattern for internationalization (there's more info on the readme file and you can use blue note as a reference)