WordPress / community-themes

A collection of Block Themes built by the WordPress community.
80 stars 33 forks source link

Add TT1 blocks #21

Closed MaggieCabrera closed 1 year ago

MaggieCabrera commented 1 year ago

This PR adds TT1 blocks to this repo. We should continue the work started in https://github.com/WordPress/theme-experiments/pull/307 on this repo now and anything else that needs updating since the last time this theme had any work done.

/cc @carolinan

Closes https://github.com/WordPress/community-themes/issues/17

MaggieCabrera commented 1 year ago

I think let's merge this one and continue working on separate PRs so the diffs are more meaningful to review, I think this still has a lot of work and there's a lot we can remove.

richtabor commented 1 year ago

I don't think this theme should be part of the repo. It's quite dated/uses a lot of CSS, functions, and isn't a great example of what a top-notch block theme is (today).

There has been a lot of developments around theming since this was originally released.

carolinan commented 1 year ago

It wont be dated once we are ready to release the update. 🙂

carolinan commented 1 year ago

To extend on my comment, yes it is dated right now, I am suggesting breaking backwards compatibility and updating the minimum required version to 6.2 and modernizing it. Updating the minimum required version will have a minimal impact because: Active Installations: 100+

MaggieCabrera commented 1 year ago

The reason why I think it's a good idea to include it in this repo is because TT1 blocks is already a community theme. It's already released under the WP username, and it's not being maintained. This way at the very least we ensure that the code is updated should people want to reference it at any point.

scruffian commented 1 year ago

I think we should remove the functions.php and all the CSS files.

MaggieCabrera commented 1 year ago

I think we should remove the functions.php and all the CSS files.

+1, we should lower the burden of maintenance as much as we can

MaggieCabrera commented 1 year ago

I opened issues for the removal of the code and other updates, if someone can ✅ this one, we can get the theme in the repo and start working on it?

MaggieCabrera commented 1 year ago

Thank you @carolinan let's make this one pretty