search

WordPress / community-themes

A collection of Block Themes built by the WordPress community.
80 stars 33 forks source link

Merge of the 146 and 142 themes #222

Open iamsam2e opened 3 months ago

iamsam2e commented 3 months ago

Combination of the two branches with some slight adjustment based off of feedback and my own assessment confirmed working on local

github-actions[bot] commented 3 months ago

Preview changes

I've detected changes to the following themes in this PR: Poetry, Purr.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

MaggieCabrera commented 3 months ago

I like the idea that the page would show a featured image and no longer has the left column, but I don't think singular is the right template for it. If we look at the template hierarchy I think page.html makes more sense and it's something users are more used to

MaggieCabrera commented 3 months ago

I would like to see https://github.com/WordPress/community-themes/pull/179 merged and have that header used for this templates, since the header we are using is way too big and probably should only be used for the home page

iamsam2e commented 2 months ago

Actioning this today and tomorrow :D