search

WordPress / community-themes

A collection of Block Themes built by the WordPress community.
80 stars 33 forks source link

Header & single updates #43

Closed ashleyshaw closed 1 year ago

ashleyshaw commented 1 year ago

6

carolinan commented 1 year ago

Thank you for working on this.

I can't remember exactly why we chose the columns block for the header. Now, on desktop width, when the post has no featured image, the space is empty, and it looks strange because the first column's width is still the same.

the post title in the large header is right aligned, left of a large open space.

There are two submissions for the content part with the sidebar: https://github.com/WordPress/community-themes/issues/6#issuecomment-1582569717

carolinan commented 1 year ago

Out of the two suggestions, I think the version where the tags, navigation links, and comments are next to the sidebar, and not below it, works better. We have to make sure that the sidebar uses headings, not paragraphs, as section headers above the blocks.

MaggieCabrera commented 1 year ago

I can't remember exactly why we chose the columns block for the header.

I believe we had issues when the text is longer than the featured image, and that wouldn't stretch to fit the content.

carolinan commented 1 year ago

We should probably remove the newsletter button, unless we want to add support for a third party news letter plugin.

carolinan commented 1 year ago

We can also increase the spacing between the latest posts in the sidebar by increasing the line-height. That works as long as we are only showing the post titles...

MaggieCabrera commented 1 year ago

I made a few changes and I think we can bring this one in and iterate